| Date | Mon, 24 Jan 2011 23:28:43 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v2 11/11] msm: Support for the MSM8960 RUMI3 target |
| |
On Wed, Jan 19, 2011 at 12:25:47PM -0800, David Brown wrote: > --- a/arch/arm/mach-msm/board-msm8960.c > +++ b/arch/arm/mach-msm/board-msm8960.c > @@ -41,6 +41,9 @@ static void __init msm8960_init_irq(void) > /* Edge trigger PPIs except AVS_SVICINT and AVS_SVICINTSWDONE */ > writel(0xFFFFD7FF, MSM_QGIC_DIST_BASE + GIC_DIST_CONFIG + 4); > > + if (machine_is_msm8960_rumi3()) > + writel(0x0000FFFF, MSM_QGIC_DIST_BASE + GIC_DIST_ENABLE_SET); > +
We really need to sort out the GIC initialization so that this kind of stuff isn't scattered throughout platform files.
In fact, I thought we had already sorted out enabling the SGI interrupts in the common gic code - it happens when you call gic_cpu_init(). So I don't think the above is required.
As far as the edge triggering PPIs, that also needs sorting properly.
|