Messages in this thread | | | Subject | Re: [PATCH 16/16] KVM-GST: adjust scheduler cpu power | From | Glauber Costa <> | Date | Mon, 24 Jan 2011 17:57:11 -0200 |
| |
On Mon, 2011-01-24 at 20:51 +0100, Peter Zijlstra wrote: > On Mon, 2011-01-24 at 16:51 -0200, Glauber Costa wrote: > > > I would really much rather see you change update_rq_clock_task() and > > > subtract your ns resolution steal time from our wall-time, > > > update_rq_clock_task() already updates the cpu_power relative to the > > > remaining time available. > > > > But then we get into the problems we already discussed in previous > > submissions, which is, we don't really want to alter any notion of > > wallclock time. Could you list any more concrete advantages of the > > specific way you proposed? > > clock_task is the time spend on the task, by not taking steal time into > account all steal time is accounted as service to whatever task was > current when the vcpu wasn't running. > > It doesn't change wall-time in the sense of gtod, only the service time > to tasks. Ok, I'll experiment with that and see how it goes.
| |