lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parport: make lockdep happy with waitlist_lock

* Alexander Gordeev <lasaine@lvk.cs.msu.su> wrote:

> parport_unregister_device should never be used when interrupts are
> enabled in hardware and irq handler is registered so there is no need
> to disable interrupts when using waitlist_lock. But there is no way to
> explain this subtle semantics to lockdep analyzer. So disable interrupts
> here too to simplify things. The price is negligible.
>
> Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
> ---
> drivers/parport/share.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index a2d9d1e..c3dd1a3 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -678,7 +678,7 @@ void parport_unregister_device(struct pardevice *dev)
>
> /* Make sure we haven't left any pointers around in the wait
> * list. */
> - spin_lock (&port->waitlist_lock);
> + spin_lock_irq (&port->waitlist_lock);

Small detail: please use a consistent coding style, i.e. 'spin_lock_irq(', not
'spin_lock_irq ('.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-01-24 16:31    [W:0.470 / U:0.408 seconds]
©2003-2014 Jasper Spaans. Advertise on this site