Messages in this thread | | | Date | Mon, 24 Jan 2011 11:17:34 +0800 | Subject | Re: [PATCH] sched: fix autogroup nice tune on UP | From | Yong Zhang <> |
| |
On Sun, Jan 23, 2011 at 11:16 PM, Pekka Enberg <penberg@kernel.org> wrote: >> tg->se->load, the reason is update_cfs_shares() >> do nothing on SMP. > > Typo here? You mean UP, right?
Ah, Yeah. Thanks for pointing it.
> > I'm not an expert on the scheduler but this looks like the wrong thing > to do. Shouldn't you fix update_cfs_shares() to work on UP properly? >
I have through about that. No-poking on update_cfs_shares() is because update_cfs_shares() is called at several hot path, like enqueue_entity()/ dequeue_entity(), but it doesn't make sense on UP.
But I guess you are right. We still need to update the load of cfs_rq after update_load_set() is called even on UP, so update_cfs_shares() is the suitable place to do that.
Will take another look at update_cfs_shares().
Thanks, Yong
-- Only stand for myself
| |