lkml.org 
[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] perf tools: Fix build by checking if extra warnings are supported
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    The -Wstack-protector and -Wvolatile-register-var warnings, for
    instance, are not supported by gcc 3.4.6.

    So fix by doing the same check we already do for -fstack-protector-all.

    With this and the other patches in this series, perf builds unmodified
    on, for instance, RHEL4.

    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    LKML-Reference: <new-submission>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/Makefile | 9 +++++++--
    1 files changed, 7 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/Makefile b/tools/perf/Makefile
    index 2b5387d..7141c42 100644
    --- a/tools/perf/Makefile
    +++ b/tools/perf/Makefile
    @@ -204,13 +204,11 @@ EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wshadow
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Winit-self
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wpacked
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wredundant-decls
    -EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wstack-protector
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wstrict-aliasing=3
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wswitch-default
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wswitch-enum
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wno-system-headers
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wundef
    -EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wvolatile-register-var
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wwrite-strings
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wbad-function-cast
    EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wmissing-declarations
    @@ -294,6 +292,13 @@ ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -fstack-protector-all),y)
    CFLAGS := $(CFLAGS) -fstack-protector-all
    endif

    +ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -Wstack-protector),y)
    + CFLAGS := $(CFLAGS) -Wstack-protector
    +endif
    +
    +ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -Wvolatile-register-var),y)
    + CFLAGS := $(CFLAGS) -Wvolatile-register-var
    +endif

    ### --- END CONFIGURATION SECTION ---

    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-01-23 03:01    [W:0.043 / U:31.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site