lkml.org 
[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] SUNRPC: Remove resource leak in svc_rdma_send_error()
    We leak the memory allocated to 'ctxt' when we return after 
    'ib_dma_mapping_error()' returns !=0.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    svc_rdma_transport.c | 1 +
    1 file changed, 1 insertion(+)

    compile tested only

    diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
    index 9df1ead..1a10dcd 100644
    --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
    +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
    @@ -1335,6 +1335,7 @@ void svc_rdma_send_error(struct svcxprt_rdma *xprt, struct rpcrdma_msg *rmsgp,
    p, 0, length, DMA_FROM_DEVICE);
    if (ib_dma_mapping_error(xprt->sc_cm_id->device, ctxt->sge[0].addr)) {
    put_page(p);
    + svc_rdma_put_context(ctxt, 1);
    return;
    }
    atomic_inc(&xprt->sc_dma_used);

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2011-01-22 22:43    [W:4.557 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site