lkml.org 
[lkml]   [2011]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] Nexus One Support
On Sat, 22 Jan 2011, Pekka Enberg wrote:

> Hi Dima!
>
> On Sat, Jan 22, 2011 at 12:35 PM, Dima Zavin <dmitriyz@google.com> wrote:
> > There's absolutely no hostility. I stated from the very beginning that
> > I appreciate the voluntary effort by a 3rd party to upstream the board
> > files. I only asked that proper authorship be attributed, which is
> > standard linux kernel patch submission procedure when the committer
> > did not originate the code.
>
> OK, that's great! It's poorly reflected in this discussion thread, though.
>
> >> who have been sitting on these patches for over a year now AFAICT.
> >
> > Even if that were true, that does not somehow revoke the original
> > author/contributor list.
>
> No, it does not. But it does make me much more sympathetic towards
> Daniel's efforts even though authorship info is misappropriated. It's
> not as if he changed copyrights or anything malicious like that so I
> do think people are making this into a bigger thing than it really is.
>
> Anyway, I hope Daniel has the time to rebase his patches on top of
> your original ones so history is preserved and we can get this stuff
> merged.

Crap. There is no history which has remotely to do anything with
Daniel patches, which are btw. very sensible and well done.

Patch 1/7 is extracted from one large dump (f5ee31ab10c1) in the
android tree, which has:

9 files changed, 1445 insertions(+), 45 deletions(-)

versus Daniels patch:

1 files changed, 42 insertions(+), 0 deletions(-)

Patch 2/7 is properly assigned to the original author.

Patch 3/7 is extracted from another large dump (37431502c4) in the
android tree which has:

11 files changed, 5336 insertions(+), 6 deletions(-)

versus Daniels patch:

4 files changed, 484 insertions(+), 1 deletions(-)

And if you look at the above 37431502c4 commit then you'll notice that
the author is Dima Zavin <dima@android.com>, while in fact the whole
commit is a conglomerate of commits from some other place with 16
different authors, but there is no way to identify who wrote what.
How the f*ck should Daniel attribute the authorship from that shit
pile? And the person who "authored" that mega commit is now
complaining.

I stoppped looking at this point as the whole "so well done" android
tree is a huge stinking pile of sh*t! Not only code wise, also the
history is completely useless due to these mega commits which have no
reference at all.

The only thing what Daniel missed is to add in the change log of his
patches:

Extracted from: git-url branch commit ID
or:
Based on: git-url branch commit ID

That's oversight and not a malicious crime and easy to repair.

The people who make a lot of noise about this including you did not
even bother to look at the patches and the originating mess, which is
in no way suitable to go near mainline in any form.

I really appreciate the well structured effort which Daniel is putting
into this. An effort which should have been done in the first place by
those who cry murder now.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-01-22 18:31    [W:0.200 / U:0.048 seconds]
©2003-2014 Jasper Spaans. Advertise on this site