Messages in this thread | | | Date | Fri, 21 Jan 2011 16:14:24 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/2] staging: synaptics: Implement error hamdling for rmi4 touch regulator |
| |
On Fri, Jan 21, 2011 at 03:54:31PM -0800, Greg KH wrote: > On Fri, Jan 21, 2011 at 03:33:30PM -0800, Dmitry Torokhov wrote: > > On Fri, Jan 21, 2011 at 12:38:15PM -0800, Greg KH wrote: > > > On Fri, Jan 21, 2011 at 03:50:36PM +0530, Naveen Kumar G wrote: > > > > From: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com> > > > > > > > > Implement the error handling for regulator in synaptics > > > > rmi4 touch screen > > > > > > > > Signed-off-by: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com> > > > > > > This patch has some fuzz and doesn't apply correctly. Care to rediff it > > > and resend it? > > > > > > > Given that this driver is a [hopefully] dead-end placeholder should we > > even spend time cleaning this up? It would be better if effor was spent > > helping Synaptics folks clean up their generic driver... > > I agree, but this looks like a new feature being added. We also can't > keep people from sending patches in, and if Synaptics never comes > through with their new driver, hey, all the better :) >
They just posted an update (rework to use our driver model) a few days ago. If they weren't working on their driver I'd agree wholeheartedly with improving this driver.
-- Dmitry
| |