Messages in this thread | | | Subject | Re: [PATCH 0/7] Nexus One Support | From | Daniel Walker <> | Date | Fri, 21 Jan 2011 16:03:13 -0800 |
| |
On Fri, 2011-01-21 at 18:49 -0500, Ted Ts'o wrote: > On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote: > > > > On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@codeaurora.org> wrote: > > > I'll add this list into the commit text .. > > > > So why is everyone bitching at Daniel when he's doing something the > > Android folks should have done themselves a long time ago? > > Two wrongs don't make a right. And it's not like not submitting > changes is wrong, although granted it's not ideal. (I'd say removing > attribution from a git commit is even worse. If you're doing the > equivalent of a cherry pick, you should preserve the Author field.
right, but it wasn't a cherrypick which was explain in the thread. So there's no wrongs here ..
Daniel
-- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |