[lkml]   [2011]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/7] Nexus One Support
On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote:
> On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <> wrote:
> > I'll add this list into the commit text ..
> So why is everyone bitching at Daniel when he's doing something the
> Android folks should have done themselves a long time ago?

Two wrongs don't make a right. And it's not like not submitting
changes is wrong, although granted it's not ideal. (I'd say removing
attribution from a git commit is even worse. If you're doing the
equivalent of a cherry pick, you should preserve the Author field.
Even if you're doing some cleanup work, as the maintainer I generally
preserve the Author line, and will simply add the fact that I did some
cleanup to the commit body. The question is who did more work; the
person who originally submitted the code, or the person who did the

- Ted

 \ /
  Last update: 2011-01-22 00:51    [W:0.520 / U:1.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site