Messages in this thread | | | Date | Fri, 21 Jan 2011 17:37:49 +0800 | Subject | Re: [PATCH] acpi: debugfs: fix buffer overflows, double free | From | Eugene Teo <> |
| |
On 1/21/11, WANG Cong <xiyou.wangcong@gmail.com> wrote: > On Thu, 20 Jan 2011 23:08:06 +0300, Vasiliy Kulikov wrote: > >> File position is not controlled, it may lead to overwrites of arbitrary >> kernel memory. Also the code may kfree() the same pointer multiple >> times. >> >> One more flaw is still present: if multiple processes open the file then >> all 3 static variables are shared, leading to various race conditions. >> They should be moved to file->private_data. >> >> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> > > Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
Thanks, Eugene
| |