Messages in this thread | | | Date | Thu, 20 Jan 2011 12:30:29 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH] RFC: abstract access to xtime_lock into a set of inline functions |
| |
On Thu, Jan 20, 2011 at 06:14:08PM +0100, Torben Hohn wrote: > the -rt patches change the xtime_lock to a raw_seqlock_t > so a pretty huge portion of the patch deals with changing > the locking functions. > > this commit uses inline functions, to hide the type > of the lock.
That's not how kernel code usually works.
> - write_seqlock(&xtime_lock); > + xtime_write_seqlock(); > do_timer(1); > - write_sequnlock(&xtime_lock); > + xtime_write_sequnlock();
However there's a pretty clear pattern of taking xtime_lock, calling do_timer and then releasing. A useful thing you could do is to rename do_timer to do_timer_locked and make do_timer take and release xtime_lock in one place.
| |