lkml.org 
[lkml]   [2011]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] perftools: Fix build error
    On 01/20/2011 02:47 PM, Ingo Molnar wrote:
    >
    > * Denis Kirjanov <dkirjanov@kernel.org> wrote:
    >
    >> Fix perftools build error (ppc64 box) with PERF_VERSION = 2.6.38.rc1.47.g12fcdb
    >> CC builtin-top.o
    >> cc1: warnings being treated as errors
    >> builtin-top.c: In function 'print_sym_table':
    >> builtin-top.c:540: error: format '%Ld' expects type 'long long int', but argument 2 has type '__u64'
    >>
    >> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
    >> ---
    >> tools/perf/builtin-top.c | 2 +-
    >> 1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    >> index 05344c6..8202a2e 100644
    >> --- a/tools/perf/builtin-top.c
    >> +++ b/tools/perf/builtin-top.c
    >> @@ -537,7 +537,7 @@ static void print_sym_table(void)
    >> if (nr_counters == 1 || !display_weighted) {
    >> struct perf_evsel *first;
    >> first = list_entry(evsel_list.next, struct perf_evsel, node);
    >> - printf("%Ld", first->attr.sample_period);
    >> + printf("%Ld", (unsigned long long)first->attr.sample_period);
    >
    > Wouldnt %Lu solve this in a cleaner way?
    >
    > Thanks,
    >
    > Ingo
    >
    I think that cleaner way is to use PRIu64.


    From 492bf54effdf8c154e76c4ca734f27ce1db46df6 Mon Sep 17 00:00:00 2001
    From: Denis Kirjanov <dkirjanov@kernel.org>
    Date: Thu, 20 Jan 2011 18:34:56 +0300
    Subject: [PATCH] perftools: Fix build error

    CC perf.o
    CC builtin-top.o
    cc1: warnings being treated as errors
    builtin-top.c: In function 'print_sym_table':
    builtin-top.c:540: error: format '%Ld' expects type 'long long int', but argument 2 has type '__u64'
    make: *** [builtin-top.o] Error 1


    Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
    ---
    tools/perf/builtin-top.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 05344c6..a7bc50b 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -40,6 +40,7 @@
    #include <stdio.h>
    #include <termios.h>
    #include <unistd.h>
    +#include <inttypes.h>

    #include <errno.h>
    #include <time.h>
    @@ -537,7 +538,7 @@ static void print_sym_table(void)
    if (nr_counters == 1 || !display_weighted) {
    struct perf_evsel *first;
    first = list_entry(evsel_list.next, struct perf_evsel, node);
    - printf("%Ld", first->attr.sample_period);
    + printf("%" PRIu64, first->attr.sample_period);
    if (freq)
    printf("Hz ");
    else
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-01-20 16:47    [W:0.025 / U:30.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site