Messages in this thread Patch in this message | | | Subject | Re: [alsa-devel] [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver | From | Tapio Vihuri <> | Date | Thu, 20 Jan 2011 14:17:33 +0200 |
| |
On Thu, 2011-01-20 at 00:11 -0800, ext Dmitry Torokhov wrote: > > How about KE_VSW case ? Shouldn't it be in the sparse_keymap_setup > {} > > also ? > > > > Indeed. Does the patch below fix it? >
Hi.
Yes it does, thank you.
Patch working (as it obviously should) OK in my environment, so
> Thanks. > > -- > Dmitry > > Input: sparse-keymap - fix KEY_VSW handling in sparse_keymap_setup > > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > We were forgetting to set up device capabilities for KEY_VSW entries. > > Reported-by: Tapio Vihuri <tapio.vihuri@nokia.com> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Tested-by: Tapio Vihuri <tapio.vihuri@nokia.com>
> --- > > drivers/input/sparse-keymap.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > diff --git a/drivers/input/sparse-keymap.c > b/drivers/input/sparse-keymap.c > index a29a7812..7729e54 100644 > --- a/drivers/input/sparse-keymap.c > +++ b/drivers/input/sparse-keymap.c > @@ -201,6 +201,7 @@ int sparse_keymap_setup(struct input_dev *dev, > break; > > case KE_SW: > + case KE_VSW: > __set_bit(EV_SW, dev->evbit); > __set_bit(entry->sw.code, dev->swbit); > break; > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Tapsa 050 4876788
| |