lkml.org 
[lkml]   [2011]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 205/260] bsg: fix incorrect device_status value
    Date
    From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

    commit 478971600e47cb83ff2d3c63c5c24f2b04b0d6a1 upstream.

    bsg incorrectly returns sg's masked_status value for device_status.

    [jejb: fix up expression logic]
    Reported-by: Douglas Gilbert <dgilbert@interlog.com>
    Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>

    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    block/bsg.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/block/bsg.c b/block/bsg.c
    index 82d5882..0c00870 100644
    --- a/block/bsg.c
    +++ b/block/bsg.c
    @@ -426,7 +426,7 @@ static int blk_complete_sgv4_hdr_rq(struct request *rq, struct sg_io_v4 *hdr,
    /*
    * fill in all the output members
    */
    - hdr->device_status = status_byte(rq->errors);
    + hdr->device_status = rq->errors & 0xff;
    hdr->transport_status = host_byte(rq->errors);
    hdr->driver_status = driver_byte(rq->errors);
    hdr->info = 0;
    --
    1.7.3.3


    \
     
     \ /
      Last update: 2011-01-02 08:39    [W:0.035 / U:123.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site