[lkml]   [2011]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[34-longterm 003/260] ath5k: drop warning on jumbo frames
    From: Luis R. Rodriguez <>

    commit 9637e516d16a58b13f6098cfe899e22963132be3 upstream.

    Jumbo frames are not supported, and if they are seen it is likely
    a bogus frame so just silently discard them instead of warning on
    them all time. Also, instead of dropping them immediately though
    move the check *after* we check for all sort of frame errors. This
    should enable us to discard these frames if the hardware picks
    other bogus items first. Lets see if we still get those jumbo
    counters increasing still with this.

    Jumbo frames would happen if we tell hardware we can support
    a small 802.11 chunks of DMA'd frame, hardware would split RX'd
    frames into parts and we'd have to reconstruct them in software.
    This is done with USB due to the bulk size but with ath5k we
    already provide a good limit to hardware and this should not be

    This is reported quite often and if it fills the logs then this
    needs to be addressed and to avoid spurious reports.

    Signed-off-by: Luis R. Rodriguez <>
    Signed-off-by: John W. Linville <>
    Signed-off-by: Paul Gortmaker <>
    drivers/net/wireless/ath/ath5k/base.c | 7 ++-----
    1 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
    index a350147..db84169 100644
    --- a/drivers/net/wireless/ath/ath5k/base.c
    +++ b/drivers/net/wireless/ath/ath5k/base.c
    @@ -1871,11 +1871,6 @@ ath5k_tasklet_rx(unsigned long data)

    - if (unlikely(rs.rs_more)) {
    - ATH5K_WARN(sc, "unsupported jumbo\n");
    - goto next;
    - }
    if (unlikely(rs.rs_status)) {
    if (rs.rs_status & AR5K_RXERR_PHY)
    goto next;
    @@ -1905,6 +1900,8 @@ ath5k_tasklet_rx(unsigned long data)
    sc->opmode != NL80211_IFTYPE_MONITOR)
    goto next;
    + if (unlikely(rs.rs_more))
    + goto next;
    next_skb = ath5k_rx_skb_alloc(sc, &next_skb_addr);


     \ /
      Last update: 2011-01-02 09:17    [W:0.020 / U:51.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site