lkml.org 
[lkml]   [2011]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 118/260] rds: fix a leak of kernel memory
    Date
    From: Eric Dumazet <eric.dumazet@gmail.com>

    commit f037590fff3005ce8a1513858d7d44f50053cc8f upstream.

    struct rds_rdma_notify contains a 32 bits hole on 64bit arches,
    make sure it is zeroed before copying it to user.

    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    CC: Andy Grover <andy.grover@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    net/rds/recv.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/net/rds/recv.c b/net/rds/recv.c
    index e2a2b93..93aadc0 100644
    --- a/net/rds/recv.c
    +++ b/net/rds/recv.c
    @@ -297,7 +297,7 @@ static int rds_still_queued(struct rds_sock *rs, struct rds_incoming *inc,
    int rds_notify_queue_get(struct rds_sock *rs, struct msghdr *msghdr)
    {
    struct rds_notifier *notifier;
    - struct rds_rdma_notify cmsg;
    + struct rds_rdma_notify cmsg = { 0 }; /* fill holes with zero */
    unsigned int count = 0, max_messages = ~0U;
    unsigned long flags;
    LIST_HEAD(copy);
    --
    1.7.3.3


    \
     
     \ /
      Last update: 2011-01-02 08:55    [W:2.600 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site