lkml.org 
[lkml]   [2011]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 127/260] net/llc: make opt unsigned in llc_ui_setsockopt()
    Date
    From: Dan Carpenter <error27@gmail.com>

    commit 339db11b219f36cf7da61b390992d95bb6b7ba2e upstream.

    The members of struct llc_sock are unsigned so if we pass a negative
    value for "opt" it can cause a sign bug. Also it can cause an integer
    overflow when we multiply "opt * HZ".

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    net/llc/af_llc.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
    index 2db6a9f..ad4296c 100644
    --- a/net/llc/af_llc.c
    +++ b/net/llc/af_llc.c
    @@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname,
    {
    struct sock *sk = sock->sk;
    struct llc_sock *llc = llc_sk(sk);
    - int rc = -EINVAL, opt;
    + unsigned int opt;
    + int rc = -EINVAL;

    lock_sock(sk);
    if (unlikely(level != SOL_LLC || optlen != sizeof(int)))
    --
    1.7.3.3


    \
     
     \ /
      Last update: 2011-01-02 08:55    [W:4.276 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site