lkml.org 
[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] serial: msm: Add support for UARTDM cores
Date
On Wed, Jan 19 2011, Jamie Iles wrote:

>> @@ -38,9 +40,20 @@ struct msm_port {
>> struct uart_port uart;
>> char name[16];
>> struct clk *clk;
>> + struct clk *pclk;
>> unsigned int imr;
>> + unsigned int *gsbi_base;
>> + int is_dm;
>> + unsigned int old_snap_state;
>> };
>
> Out of interest, what does .is_dm mean? Is that obvious to someone who
> knows about msm?

It would be clear to people rather familiar with the chip, but I agree
it's probably not that clear of a name.

We have two UART blocks we use in the MSMs, the older one, supported by
this driver before this change, and a newer one that was designed to
work with our DMA engine (known as the Data Mover, or dm). This newer
UART can be used in a somewhat compatible manner when being used for
serial-port type operations.

I'm not sure what would be a better name for the flag, though. The
block is called UARTDM.

David

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


\
 
 \ /
  Last update: 2011-01-19 18:35    [from the cache]
©2003-2011 Jasper Spaans