lkml.org 
[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] BKL: move CONFIG_BKL to staging
Date
On Wednesday 19 January 2011, Nick Bowler wrote:
> I think this patch is not very nice. It will cause working kernel
> configurations to turn into broken kernel configurations when the user
> does 'make oldconfig', with no warning.
>
> These drivers that use the BKL work fine. Removing working features
> with no adequate replacement available seems like a serious regression
> to me.

I wouldn't call it a serious regression since the code is still there
and both the symptom and the solution are rather obvious. What's more
important is to make any people still relying on the code aware that
it's going away unless someone fixes it, so they have the chance to
send patches or pay someone to fix it for them.

The remaining drivers that are still relying on the BKL are very
rarely used and for the less obscure ones (ufs, ipx and x.25), people
have volunteered to fix them (though I have seen no proper patches
for these yet). For the rest, I suppose if nobody complains, they
can actually go away, according to the logic that if nobody is using
them, they most likely are broken anyway and more a security risk than
they are worth.

Anyway, it seems that you're lucky this time, because I managed to miss
the merge window by being away from my test box for the most part of it.

Arnd


\
 
 \ /
  Last update: 2011-01-19 17:21    [W:0.213 / U:0.964 seconds]
©2003-2014 Jasper Spaans. Advertise on this site