lkml.org 
[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] memcg: fix USED bit handling at uncharge in THP
Hello KAMEZAWA-san,

On Tue, Jan 18, 2011 at 11:40:49AM +0900, KAMEZAWA Hiroyuki wrote:
> +void mem_cgroup_split_huge_fixup(struct page *head, struct page *tail)
> +{
> + struct page_cgroup *head_pc = lookup_page_cgroup(head);
> + struct page_cgroup *tail_pc = lookup_page_cgroup(tail);
> + unsigned long flags;
> +
> + /*
> + * We have no races witch charge/uncharge but will have races with
> + * page state accounting.
> + */
> + move_lock_page_cgroup(head_pc, &flags);
> +
> + tail_pc->mem_cgroup = head_pc->mem_cgroup;
> + smp_wmb(); /* see __commit_charge() */

I thought the barriers were needed because charging does not hold the
lru lock. But here we do, and all the 'lockless' read-sides do so as
well. Am I missing something or can this barrier be removed?

Hannes


\
 
 \ /
  Last update: 2011-01-19 13:13    [W:0.090 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site