Messages in this thread | | | Date | Tue, 18 Jan 2011 23:09:36 +0000 | From | Joel Becker <> | Subject | Re: [PATCH] ocfs2: Make OCFS2_FS depend on CONFIGFS_FS |
| |
On Sat, Jan 15, 2011 at 03:16:10PM -0800, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@linux-iscsi.org> > > This patch fixes the following kconfig error after changing > CONFIGFS_FS -> select SYSFS: > > fs/sysfs/Kconfig:1:error: recursive dependency detected! > fs/sysfs/Kconfig:1: symbol SYSFS is selected by CONFIGFS_FS > fs/configfs/Kconfig:1: symbol CONFIGFS_FS is selected by OCFS2_FS > fs/ocfs2/Kconfig:1: symbol OCFS2_FS depends on SYSFS
<snip>
> diff --git a/fs/ocfs2/Kconfig b/fs/ocfs2/Kconfig > index ab152c0..77a8de5 100644 > --- a/fs/ocfs2/Kconfig > +++ b/fs/ocfs2/Kconfig > @@ -1,7 +1,6 @@ > config OCFS2_FS > tristate "OCFS2 file system support" > - depends on NET && SYSFS > - select CONFIGFS_FS > + depends on NET && SYSFS && CONFIGFS_FS
Isn't this exactly what Linus just said not to do? I don't want to know that I need to select configfs. Shouldn't it instead just be:
select NET select CONFIGFS_FS
Linus?
Joel
--
| |