lkml.org 
[lkml]   [2011]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] PCI: allocate essential resources before reserving hotplug resources
Date
On Tuesday, January 18, 2011 02:42:53 pm Ram Pai wrote:
> On Tue, Jan 18, 2011 at 01:52:06PM -0700, Bjorn Helgaas wrote:

> > This is a PCI-specific issue, so I'm not comfortable adding add_size
> > to struct resource. That penalizes all resource users while only
> > helping PCI. Also, the struct resource lives forever, and the
> > add_size information is only useful while we're configuring the
> > bridge.
>
> Any suggestion on how to do this without adding a field to struct resource?

It *is* a little ugly. You compute some of this info early, in
pbus_size_io/mem(), but it's not used until later. Maybe it would
make sense in struct pci_bus? That's a pain, too, because then you
have to test the resource type in adjust_resources_sorted() but at
least it's a per-PCI bridge structure.

Bjorn


\
 
 \ /
  Last update: 2011-01-18 23:15    [W:0.064 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site