lkml.org 
[lkml]   [2011]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/9 v2] Altera FPGA based CI driver module.
    Date
    В сообщении от 16 января 2011 19:52:38 автор Mauro Carvalho Chehab написал:
    > Em 02-01-2011 10:01, Igor M. Liplianin escreveu:
    > > An Altera FPGA CI module for NetUP Dual DVB-T/C RF CI card.
    > >
    > > Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
    >
    > Igor,
    >
    > There's something wrong with this patch. I got lots of error after applying
    > it:
    >
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_read_attribute_mem':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:304:
    > multiple definition of `netup_ci_read_attribute_mem'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:241: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function `netup_ci_op_cam':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:269:
    > multiple definition of `netup_ci_op_cam'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:171: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_slot_shutdown':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:364:
    > multiple definition of `netup_ci_slot_shutdown'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:293: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_slot_ts_ctl':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:370:
    > multiple definition of `netup_ci_slot_ts_ctl'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:320: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_write_cam_ctl':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:322:
    > multiple definition of `netup_ci_write_cam_ctl'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:259: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_read_cam_ctl':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:315:
    > multiple definition of `netup_ci_read_cam_ctl'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:252: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_write_attribute_mem':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:310:
    > multiple definition of `netup_ci_write_attribute_mem'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:247: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_poll_ci_slot_status':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:448:
    > multiple definition of `netup_poll_ci_slot_status'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:403: first defined here
    > drivers/media/video/cx23885/altera-ci.o: In function
    > `netup_ci_slot_reset':
    > /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:327:
    > multiple definition of `netup_ci_slot_reset'
    > drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
    > a/video/cx23885/cimax2.c:264: first defined here
    >
    >
    > Please fix it and submit a new version. The better is to replace all those
    > new symbols to start with altera_ci.
    I see, allyesconfig...

    >
    > While here, please, on the first patch, move the Altera FPGA driver to
    > staging, to give people some time do discuss about it.
    It means that cx23885 driver will depend on staging. Is it OK?

    >
    > PS.: there are a few CodingStyle errors on this patch. Please always review
    > your patches with ./scripts/checkpatch.pl.
    I'll do it.
    >
    > Thanks!
    > Mauro

    --
    Igor M. Liplianin
    Microsoft Windows Free Zone - Linux used for all Computing Tasks
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-18 20:33    [W:0.046 / U:61.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site