Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/3] trusted-keys: avoid scattring va_end() | Date | Mon, 17 Jan 2011 09:39:35 +0000 |
| |
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
> From 65b41710a476deae2e0899a4df40c02d199a4ee3 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Date: Mon, 17 Jan 2011 09:27:27 +0900 > Subject: [PATCH 3/3] trusted-keys: avoid scattring va_end() > > We can avoid scattering va_end() within the > > va_start(); > for (;;) { > > } > va_end(); > > loop, assuming that crypto_shash_init()/crypto_shash_update() return 0 on > success and negative value otherwise. > > Make TSS_authhmac()/TSS_checkhmac1()/TSS_checkhmac2() similar to TSS_rawhmac() > by removing "va_end()/goto" from the loop. > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: David Howells <dhowells@redhat.com>
| |