Messages in this thread | | | Date | Mon, 17 Jan 2011 20:35:55 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 04/16] input: tnetv107x-touchscreen: don't treat NULL clk as an error |
| |
On Mon, Jan 17, 2011 at 08:25:35PM -0800, Dmitry Torokhov wrote: > On Tue, Jan 11, 2011 at 09:56:41PM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 11, 2011 at 12:43:41PM +0000, Jamie Iles wrote: > > > clk_get() returns a struct clk cookie to the driver and some platforms > > > may return NULL if they only support a single clock. clk_get() has only > > > failed if it returns a ERR_PTR() encoded pointer. > > > > > > Cc: Cyril Chemparathy <cyril@ti.com> > > > Cc: linux-input@vger.kernel.org > > > Signed-off-by: Jamie Iles <jamie@jamieiles.com> > > > > Applied both, thank you Jamie. > > > > Actually, if we pass clk that is NULL along we going to get oops on many > arches, so I am going to change it to IS_ERR_OR_NULL. >
Oh, wait... OK, I got confused by the changelog. IS_ERR is proper, sorry.
-- Dmitry
| |