Messages in this thread | | | Subject | Re: [PATCH 2/3] trusted-keys: check for NULL before using it | From | Mimi Zohar <> | Date | Mon, 17 Jan 2011 16:02:06 -0500 |
| |
On Mon, 2011-01-17 at 09:41 +0900, Tetsuo Handa wrote: > From 8118c3d0d6f2b291d56e2f4475f2aa5156299cf3 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Date: Mon, 17 Jan 2011 09:25:34 +0900 > Subject: [PATCH 2/3] trusted-keys: check for NULL before using it > > TSS_rawhmac() checks for data != NULL before using it. > We should do the same thing for TSS_authhmac(). > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
> --- > security/keys/trusted_defined.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/security/keys/trusted_defined.c b/security/keys/trusted_defined.c > index 7b21795..f7d0677 100644 > --- a/security/keys/trusted_defined.c > +++ b/security/keys/trusted_defined.c > @@ -148,6 +148,11 @@ static int TSS_authhmac(unsigned char *digest, const unsigned char *key, > if (dlen == 0) > break; > data = va_arg(argp, unsigned char *); > + if (!data) { > + ret = -EINVAL; > + va_end(argp); > + goto out; > + } > ret = crypto_shash_update(&sdesc->shash, data, dlen); > if (ret < 0) { > va_end(argp);
| |