Messages in this thread | | | Date | Mon, 17 Jan 2011 10:55:34 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH -perf/perf/core 4/6] perf: Add strfilter for general purpose string filter |
| |
Em Mon, Jan 17, 2011 at 10:40:29AM -0200, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jan 13, 2011 at 09:46:17PM +0900, Masami Hiramatsu escreveu: > > Add strfilter for general purpose string filter. > > Every filter rules are descrived by glob matching pattern > > and '!' prefix which means Logical NOT. > > A strfilter consists of those filter rules connected > > with '&' and '|'. A set of rules can be folded by using > > '(' and ')'. It also accepts spaces around rules and those > > You're not checking strfilter__alloc results, I'm fixing this for you > this time :-)
Not really, please check strdup() result and strfilter__delete() needs to traverse all the nodes, not just the ones pointed at the root, right?
Please address these problems and resubmit this patch, I merged the first three, folding the documentation one you sent for --funcs into the third, where the feature was added.
Please rebase from my perf/core branch at:
http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=shortlog;h=refs/heads/perf/core
- Arnaldo
| |