lkml.org 
[lkml]   [2011]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] configfs: change depends -> select SYSFS
From
Date
On Sun, 2011-01-16 at 09:54 -0800, Linus Torvalds wrote:
> On Sat, Jan 15, 2011 at 1:10 PM, Nicholas A. Bellinger
> <nab@linux-iscsi.org> wrote:
> >
> > This patch changes configfs to select SYSFS to fix the following:
> >
> > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
>
> I'm ok with this part. But:
>
> > This patch also fixes whitespace breakage in the 'help' section.
>
> This is just bogus. The help text is _supposed_ to have that extra
> indentation so that it stands out from the rest of the Kconfig stuff.
>

Ahh, thanks for the clarification here. At some point I saw a patch
that did make this change, and it stuck with me that it was the
preferred method. This won't happen again.

The updated patch to keep the extra indentation for configfs, along with
the three extra 'depends CONFIGFS_FS' patches from yesterday are
available in a pullable branch against this afternoon's
linux-2.6.git/master here:

git://git.kernel.org/pub/scm/linux/kernel/git/nab/scsi-post-merge-2.6.git for-linus

Please let me know if you have any questions,

--nab

Nicholas Bellinger (4):
configfs: change depends -> select SYSFS
net: Make NETCONSOLE_DYNAMIC depend on CONFIGFS_FS
dlm: Make DLM depend on CONFIGFS_FS
ocfs2: Make OCFS2_FS depend on CONFIGFS_FS

drivers/net/Kconfig | 3 +--
fs/configfs/Kconfig | 4 ++--
fs/dlm/Kconfig | 3 +--
fs/ocfs2/Kconfig | 3 +--
4 files changed, 5 insertions(+), 8 deletions(-)



\
 
 \ /
  Last update: 2011-01-16 22:47    [W:0.525 / U:0.884 seconds]
©2003-2014 Jasper Spaans. Advertise on this site