Messages in this thread | | | From | Rasesh Mody <> | Date | Wed, 12 Jan 2011 14:55:25 -0800 | Subject | RE: [PATCH 2/3] bna: Remove unnecessary memset(,0,) |
| |
>From: Joe Perches [mailto:joe@perches.com] >Sent: Wednesday, January 12, 2011 1:21 PM > >kzalloc'd memory doesn't need a memset to 0. > >Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Rasesh Mody <rmody@brocade.com>
>--- > drivers/net/bna/bnad_ethtool.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > >diff --git a/drivers/net/bna/bnad_ethtool.c >b/drivers/net/bna/bnad_ethtool.c >index 99be5ae..142d604 100644 >--- a/drivers/net/bna/bnad_ethtool.c >+++ b/drivers/net/bna/bnad_ethtool.c >@@ -275,7 +275,6 @@ bnad_get_drvinfo(struct net_device *netdev, struct >ethtool_drvinfo *drvinfo) > > ioc_attr = kzalloc(sizeof(*ioc_attr), GFP_KERNEL); > if (ioc_attr) { >- memset(ioc_attr, 0, sizeof(*ioc_attr)); > spin_lock_irqsave(&bnad->bna_lock, flags); > bfa_nw_ioc_get_attr(&bnad->bna.device.ioc, ioc_attr); > spin_unlock_irqrestore(&bnad->bna_lock, flags); >-- >1.7.3.3.398.g0b0cd.dirty
Joe, Patch looks ok to me. Thanks, Rasesh
| |