Messages in this thread | | | Date | Wed, 12 Jan 2011 09:47:50 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 1/2] memcg: remove unnecessary BUG_ON |
| |
On Tue, 11 Jan 2011 17:51:11 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> Now memcg in unmap_and_move checks BUG_ON of charge. > mem_cgroup_prepare_migration returns either 0 or -ENOMEM. > If it returns -ENOMEM, it jumps out unlock without the check. > If it returns 0, it can pass BUG_ON. So it's meaningless. > Let's remove it. > > Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> > Cc: Balbir Singh <balbir@linux.vnet.ibm.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
| |