Messages in this thread | | | Date | Tue, 11 Jan 2011 08:37:29 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH] slub: Fix sysfs circular locking dependency |
| |
On 1/10/11 10:30 PM, David Rientjes wrote: > On Mon, 10 Jan 2011, Christoph Lameter wrote: > >> New patch that just covers the slub changes. >> >> Subject: slub: Avoid use of slub_lock in show_slab_objects() >> >> The purpose of the locking is to prevent removal and additions >> of nodes when statistics are gathered for a slab cache. So we >> need to avoid racing with memory hotplug functionality. >> >> It is enough to take the memory hotplug locks there instead >> of the slub_lock. >> >> online_pages() currently does not acquire the memory_hotplug >> lock. Another patch will be submitted by the memory hotplug >> authors to take the memory hotplug lock and describe the >> uses of the memory hotplug lock to protect against >> adding and removal of nodes from non hotplug data structures. >> >> Signed-off-by: Christoph Lameter<cl@linux.com> > Acked-by: David Rientjes<rientjes@google.com>
Is this safe to be applied without the other hotplug parts?
| |