Messages in this thread | | | From | Rabin Vincent <> | Date | Tue, 11 Jan 2011 21:38:07 +0530 | Subject | Re: [PATCH] ux500: Add Rohm BH1780GLI Light Sensor to i2c_board_info |
| |
On Tue, Jan 11, 2011 at 18:40, Lee Jones <lee.jones@linaro.org> wrote: > Signed-off-by: Lee Jones <lee.jones@linaro.org> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > --- > arch/arm/mach-ux500/board-mop500.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c > index 2635bb7..ff67408 100644 > --- a/arch/arm/mach-ux500/board-mop500.c > +++ b/arch/arm/mach-ux500/board-mop500.c > @@ -134,6 +134,15 @@ static struct i2c_board_info mop500_i2c0_devices[] = { > }, > }; > > +static struct i2c_board_info mop500_i2c2_devices[] = { > +#if defined(CONFIG_SENSORS_BH1780) > + { > + /* Light sensor Rohm BH1780GLI */ > + I2C_BOARD_INFO("bh1780", 0x29), > + }, > +#endif > +};
You need to take care of the case where the driver is built as a module (by adding a || defined(..._MODULE)). It would actually be better if you instead get rid of the ifdef entirely, since they get really ugly if you add them for every device here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |