Messages in this thread | | | Date | Wed, 12 Jan 2011 00:04:37 +0800 | From | Américo Wang <> | Subject | Re: [PATCH] /proc/kcore: fix seeking |
| |
On Mon, Jan 10, 2011 at 09:42:29AM -0500, Dave Anderson wrote: >From: Dave Anderson <anderson@redhat.com> > >Commit 34aacb2920667d405a8df15968b7f71ba46c8f18 >("procfs: Use generic_file_llseek in /proc/kcore") >broke seeking on /proc/kcore. This changes it back >to use default_llseek in order to restore the original >behavior. > >The problem with generic_file_llseek is that it only >allows seeks up to inode->i_sb->s_maxbytes, which is >2GB-1 on procfs, where the memory file offset values in >the /proc/kcore PT_LOAD segments may exceed or start >beyond that offset value. >
Is the race solved? Using default_llseek() still races with read_kcore() on fpos, AFAIK.
-- Live like a child, think like the god.
| |