Messages in this thread | | | Date | Tue, 11 Jan 2011 11:46:48 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH v3 3/7] hugetlbfs: Change remove_from_page_cache |
| |
On Tue, Jan 11, 2011 at 02:22:07PM +0900, Minchan Kim wrote: > This patch series changes remove_from_page_cache's page ref counting > rule. Page cache ref count is decreased in delete_from_page_cache. > So we don't need decreasing page reference by caller. > > Cc: William Irwin <wli@holomorphy.com> > Acked-by: Hugh Dickins <hughd@google.com> > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Reviewed-by: Johannes Weiner <hannes@cmpxchg.org> > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Thanks.
> --- > fs/hugetlbfs/inode.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 9885082..b9eeb1c 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -332,8 +332,7 @@ static void truncate_huge_page(struct page *page) > { > cancel_dirty_page(page, /* No IO accounting for huge pages? */0); > ClearPageUptodate(page); > - remove_from_page_cache(page); > - put_page(page); > + delete_from_page_cache(page); > } > > static void truncate_hugepages(struct inode *inode, loff_t lstart)
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |