lkml.org 
[lkml]   [2011]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ext4: fix possible overflow in ext4_trim_fs()
    On Mon, 20 Dec 2010, Ted Ts'o wrote:

    > On Thu, Nov 25, 2010 at 03:11:17PM +0100, Lukas Czerner wrote:
    > > When determining last group through ext4_get_group_no_and_offset() the
    > > result may be wrong in cases when range->start and range-len are too
    > > big, because it may overflow when summing up those two numbers.
    > >
    > > Fix that by checking range->len and limit its value to
    > > ext4_blocks_count(). This commit was tested by myself with expected
    > > result.
    > >
    > > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    >
    > Added to the ext4 patch queue. Thanks for the ping.
    >
    > - Ted
    >

    Hi Ted,

    Actually the patch is not enough, there is still a possibility for
    overflow to happen. Jan Kara notice the same bug in ext3 batched discard
    implementation. I am sorry for this, I'll sen updated patch ASAP.

    -Lukas


    \
     
     \ /
      Last update: 2011-01-10 12:27    [W:0.027 / U:30.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site