lkml.org 
[lkml]   [2010]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] MMC: move regulator handling closer to core v3
    From
    2010/9/9 Andrew Morton <akpm@linux-foundation.org>:
    > On Sun,  5 Sep 2010 11:05:38 +0200
    > Linus Walleij <linus.walleij@stericsson.com> wrote:
    >> +     if (host->vcc) {
    >> +             int ret;
    >> +
    >> +             if (power_mode == MMC_POWER_UP)
    >> +                     ret = mmc_regulator_set_ocr(host->mmc, host->vcc, vdd);
    >> +             else if (power_mode == MMC_POWER_OFF)
    >> +                     ret = mmc_regulator_set_ocr(host->mmc, host->vcc, 0);
    >> +     }
    >
    > There's no point in copying the return value into a local then ignoring
    > it.  mmc_regulator_set_ocr() can return a negative errno so we should
    > test for that, clean up and propagate the error.

    OK I'll fix.

    > The same comments apply to mmci_set_ios().

    OK.

    Yours,
    Linus Walleij
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-09 09:05    [W:0.025 / U:59.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site