Messages in this thread | | | Date | Thu, 9 Sep 2010 18:14:09 +0100 | From | Matthew Garrett <> | Subject | Re: [Intel-gfx] [PATCH] i915: Add native backlight control |
| |
On Thu, Sep 09, 2010 at 06:09:40PM +0100, Chris Wilson wrote: > On Wed, 8 Sep 2010 12:32:18 -0400, Matthew Garrett <mjg@redhat.com> wrote: > > Not all systems expose a firmware or platform mechanism for changing the > > backlight intensity on i915, so add native driver support. > > This will conflict with a similar patch I have in drm-intel-next to unify > the various bits of code that were attempting to modify the BLC PWM, each > in their own unique fashion. > > I'll respin this native interface on top of that. Do you want to add a > native RAW interface all in one go, or to base it on the current > backlight_device and then to add the RAW property with this patch set?
I don't think providing a native interface in i915 is beneficial without providing the type information - userspace just doesn't have any way to identify the correct device otherwise.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |