lkml.org 
[lkml]   [2010]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/27] KVM: MMU: Refactor mmu_alloc_roots function
On Wed, Sep 08, 2010 at 03:16:59AM -0400, Avi Kivity wrote:
> On 09/07/2010 11:39 PM, Marcelo Tosatti wrote:
> >
> >> @@ -2406,16 +2441,11 @@ static int mmu_alloc_roots(struct kvm_vcpu *vcpu)
> >> root_gfn = pdptr>> PAGE_SHIFT;
> >> if (mmu_check_root(vcpu, root_gfn))
> >> return 1;
> >> - } else if (vcpu->arch.mmu.root_level == 0)
> >> - root_gfn = 0;
> >> - if (vcpu->arch.mmu.direct_map) {
> >> - direct = 1;
> >> - root_gfn = i<< 30;
> >> }
> >> spin_lock(&vcpu->kvm->mmu_lock);
> >> kvm_mmu_free_some_pages(vcpu);
> >> sp = kvm_mmu_get_page(vcpu, root_gfn, i<< 30,
> >> - PT32_ROOT_LEVEL, direct,
> >> + PT32_ROOT_LEVEL, 0,
> >> ACC_ALL, NULL);
> > Should not write protect the gfn for nonpaging mode.
> >
>
> nonpaging mode should have direct_map set, so wouldn't enter this path
> at all.

Hmm, actually the nonpaging path does not set direct_map. I'll fix this
too in v4. Thanks.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632



\
 
 \ /
  Last update: 2010-09-08 11:21    [W:0.126 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site