| Date | Wed, 8 Sep 2010 08:37:45 -0700 | From | Dmitry Torokhov <> | Subject | Re: [patch 02/30] input: misc/hp_sdc_rtc: semaphore cleanup |
| |
On Tue, Sep 07, 2010 at 02:31:58PM -0000, Thomas Gleixner wrote: > Get rid of init_MUTEX[_LOCKED]() and use sema_init() instead. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Dmitry Torokhov <dtor@mail.ru>
All 3 look good to me Thomas, please merge with the rest of the patch series.
> > --- > drivers/input/misc/hp_sdc_rtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6/drivers/input/misc/hp_sdc_rtc.c > =================================================================== > --- linux-2.6.orig/drivers/input/misc/hp_sdc_rtc.c > +++ linux-2.6/drivers/input/misc/hp_sdc_rtc.c > @@ -104,7 +104,7 @@ static int hp_sdc_rtc_do_read_bbrtc (str > t.endidx = 91; > t.seq = tseq; > t.act.semaphore = &tsem; > - init_MUTEX_LOCKED(&tsem); > + sema_init(&tsem, 0); > > if (hp_sdc_enqueue_transaction(&t)) return -1; > > @@ -698,7 +698,7 @@ static int __init hp_sdc_rtc_init(void) > return -ENODEV; > #endif > > - init_MUTEX(&i8042tregs); > + sema_init(&i8042tregs, 1); > > if ((ret = hp_sdc_request_timer_irq(&hp_sdc_rtc_isr))) > return ret; > >
-- Dmitry
|