Messages in this thread | | | Date | Tue, 07 Sep 2010 21:17:20 +0200 | From | Éric Piel <> | Subject | Re: [PATCH] lis3: Add axes module parameter for custom axis-mapping |
| |
Op 07-09-10 18:10, Takashi Iwai schreef: > At Tue, 07 Sep 2010 17:54:58 +0200, : >>> >>> +module_param_array_named(axes, lis3_dev.axis_map, int, NULL, 0644); >>> +MODULE_PARM_DESC(axes, "Axis-mapping for x,y,z directions"); >> But now there is no check at all about the value being between 1 and 3, >> is there? >> I think it's still necessary to have a small function which checks for >> correct values, otherwise the user could read a bit anywhere in the memory. > > Ah, right, it's accessing the array index. This must be fixed indeed. > Another revised version below. > It seems to be the same patch as the previous version. You probably attached the wrong patch.
Cheers, Eric
| |