Messages in this thread | | | Subject | Re: [PATCH 09/10] VFS: Remove read-only checks from dentry_permission | From | Dave Hansen <> | Date | Tue, 07 Sep 2010 08:58:34 -0700 |
| |
On Mon, 2010-09-06 at 10:50 +1000, NeilBrown wrote: > It is not sufficient to depend on the the "filesystem is readonly" > tests in dentry_permission as it does not check if the vfsmnt is > readonly. > All call sites already call mnt_want_write or __mnt_is_readonly which > includes the test on MS_RDONLY. > > So remove this test from dentry_permission as it simply duplicates > tests done elsewhere.
Yeah, I remember auditing all of the dentry_permission() callers and moving them over to mnt_want_write() and friends as well. I don't quite remember why we didn't take this step back then, but it looks sane to me.
-- Dave
| |