[lkml]   [2010]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[RESEND/PATCH 3/6] USB: musb-gadget: enable autoclear for OUT transfer in both DMA 0 and DMA 1
    From: Ming Lei <>

    This patch fixes one bugs of OUT transfer in double buffer case:

    -the current code only enable autoclear for dma mode 1, and not
    for dma mode 0

    Without this patch, test #5 of usbtest can't be passed if we
    configure musb as g_zero and use fifo mode 3 to enable double
    buffer mode.

    With this patch and the following patch(fix dma length),
    on my beagle B5, test#5(queued bulk out) may go beyond
    18Mbyte/s(seems dma mode 0 is quicker in double buffer case)
    if musb is configured as g_zero and fifo mode 3 is taken, follows
    the test command:

    #./testusb -D DEV_NAME -c 1024 -t 5 -s 32768 -g 8 [1]

    Also I have tested this patch can't make g_ether broken.

    [1],source of testusb : tools/usb/testusb.c under linux kernel;

    Signed-off-by: Ming Lei <>
    Cc: David Brownell <>
    Cc: Felipe Balbi <>
    Cc: Anand Gadiyar <>
    Cc: Mike Frysinger <>
    Cc: Sergei Shtylyov <>
    drivers/usb/musb/musb_gadget.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
    index f206c94..176e127 100644
    --- a/drivers/usb/musb/musb_gadget.c
    +++ b/drivers/usb/musb/musb_gadget.c
    @@ -643,8 +643,8 @@ static void rxstate(struct musb *musb, struct musb_request *req)

    -#ifdef USE_MODE1
    +#ifdef USE_MODE1
    /* csr |= MUSB_RXCSR_DMAMODE; */

    /* this special sequence (enabling and then

     \ /
      Last update: 2010-09-07 17:27    [W:0.026 / U:0.604 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site