Messages in this thread | | | Date | Sat, 4 Sep 2010 23:24:26 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals |
| |
On Sat, Sep 04, 2010 at 07:07:48PM -0400, Javier Martinez Canillas wrote: > > Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> > --- > drivers/staging/xgifb/XGI_main.h | 2 ++ > drivers/staging/xgifb/XGI_main_26.c | 6 ++++++ > 2 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h > index 72448e8..93837f3 100644 > --- a/drivers/staging/xgifb/XGI_main.h > +++ b/drivers/staging/xgifb/XGI_main.h > @@ -345,7 +345,9 @@ static int XGIfb_userom = 0; > static int XGIfb_registered; > static int XGIfb_tvmode = 0; > static int XGIfb_mem = 0; > +#ifndef MODULE > static int XGIfb_pdc = 0; > +#endif
Ick, no, don't add conditionals, fix the code to not need such nonsense.
thanks,
greg k-h
| |