lkml.org 
[lkml]   [2010]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/8] drivers/net/wireless/iwlwifi/iwl-agn.c: Fix return value from an unsigned function
    Date
    The function has an unsigned return type, but returns a negative constant
    to indicate an error condition. Another error condition in the same
    function is indicated by returning 0, and indeed the only call to the
    function checks for 0 to detect errors, so the return of a negative value
    it converted to a return of 0.

    A sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @exists@
    identifier f;
    constant C;
    @@

    unsigned f(...)
    { <+...
    * return -C;
    ...+> }
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
    index ad0e67f..86b55c2 100644
    --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
    +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
    @@ -369,7 +369,7 @@ static unsigned int iwl_hw_get_beacon_cmd(struct iwl_priv *priv,

    if (!priv->beacon_ctx) {
    IWL_ERR(priv, "trying to build beacon w/o beacon context!\n");
    - return -EINVAL;
    + return 0;
    }

    /* Initialize memory */


    \
     
     \ /
      Last update: 2010-09-05 21:01    [W:0.022 / U:31.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site