[lkml]   [2010]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/24] arm: mm: add proc info for ScorpionMP
On Fri, Aug 27, 2010 at 05:04:32PM +0100, Catalin Marinas wrote:
> On Fri, 2010-08-27 at 16:29 +0100, Daniel Walker wrote:
> > > In general, I would have liked a different way (still ID-based) of
> > > handling such issues without duplicating the whole structure. But I see
> > > this becoming the standard as proc-v6.S follows it as well.
> >
> > This whole thing was something Russell specifically asked for (and
> > practically wrote for me).
> Yes, I know and I'm not saying that you should change it in this patch.
> It's just that I would have liked to only duplicate the setup function
> rather than the whole procinfo structure.

If you think about it, the only way to do that is to make things even
more complicated than they already are by separating out the rest of
the structure from the ID, mask, and setup functions. At that point,
what if someone has just one change to the other values in the structure?
They'll have the same complaint as you have, and they'll want it split
in an entirely different way.

 \ /
  Last update: 2010-09-04 16:35    [W:0.100 / U:1.376 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site