lkml.org 
[lkml]   [2010]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectbna: potential null dereference
Hi,

stanse found a potential null dereference:
bnad_cb_tx_cleanup
-> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
-> -- tcb cannot be null now --
-> if (!tcb || (!tcb->unmap_q))

The thing is I have no idea whether the second parameter of cleanup may
be null (move assignment after the check) or not (remove the check)

Could you fix that?

thanks,
--
js


\
 
 \ /
  Last update: 2010-09-04 15:03    [W:0.030 / U:9.104 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site