[lkml]   [2010]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRE: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC
    Mark, have you had a chance to double check my changes based on the comments you made? 


    -----Original Message-----
    From: Anton Vorontsov []
    Sent: Thursday, September 02, 2010 10:48 AM
    To: Rhyland Klein
    Cc:;;; Andrew Chew;;
    Subject: Re: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC

    On Thu, Sep 02, 2010 at 10:29:46AM -0700, wrote:
    > From: Rhyland Klein <>
    > this driver depends on I2C and uses SMBUS for communication with the host.
    > Addressed comments from reviews by Mark Brown and Jean Delvare.
    > * Cleaned up whitespace and alignment issues
    > * changed return codes to more appropriate values
    > * change Kconfig option name to be consistent with existing devices
    > * removed global struct and moved to device specific data
    > * changed printk to dev_dbg

    The driver looks good to me. But I'll wait a day or two for Jean's
    and Mark's Acked-by or Reviewed-by tags before applying, just to
    give them some credit for reviwing this driver.


    Anton Vorontsov
     \ /
      Last update: 2010-09-04 23:03    [W:0.022 / U:34.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site