lkml.org 
[lkml]   [2010]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] KVM: SVM: Clean up rip handling in vmrun emulation
On Fri, Sep 03, 2010 at 11:29:11PM +0200, Alexander Graf wrote:
> Any reason we can't use the next_rip information here? A hypervisor
> could potentially do badness and put a prefix here, thus break all the
> logic, right?

Next_rip is not available on older hardware. Yes, this problem exists in
theory (as it does with rdmsr/wrmsr, cpuid, ... too). But a fix for this
on non-next-rip capable hardware would involve the instruction emulator
and kills all performance there. So we use this stupid and fast solution
here which works for all hypervisors I tested :-)

> (yes, I know, I wrote that code, but still ...)

When you wrote that code next_rip capable hardware was not available, so
don't worry :-)


Joerg


\
 
 \ /
  Last update: 2010-09-04 21:35    [W:0.032 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site