lkml.org 
[lkml]   [2010]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/34] VFS: Make clone_mnt() and copy_tree() return error codes
(Resend with correct email for Ram Pai)

On Thu, Sep 30, 2010 at 11:51:30AM +0200, Miklos Szeredi wrote:
> On Thu, 16 Sep 2010, Valerie Aurora wrote:
> > copy_tree() can theoretically fail in a case other than ENOMEM, but
> > always returns NULL which is interpreted by callers as -ENOMEM.
> > Convert to return an explicit error. Convert clone_mnt() for
> > consistency and because union mounts will add new error cases.
>
> I think it makes sense to push this fix to 2.6.37 independently of the
> other patches.
>
> Acked-by: Miklos Szeredi <mszeredi@suse.cz>

I'm certainly not going to argue, but I spent an hour trying to
trigger the non-ENOMEM case (below) and failed - maybe it's
unreachable?

> > @@ -1212,11 +1216,12 @@ struct vfsmount *copy_tree(struct vfsmount *mnt, struct dentry *dentry,
> > struct path path;
> >
> > if (!(flag & CL_COPY_ALL) && IS_MNT_UNBINDABLE(mnt))
> > - return NULL;
> > + return ERR_PTR(-EINVAL);

Ram, do you remember how this worked?

-VAL


\
 
 \ /
  Last update: 2010-10-03 22:25    [W:0.446 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site